Add crps_csg0 for 0-censored shifted gamma distribution#97
Add crps_csg0 for 0-censored shifted gamma distribution#97frazane merged 3 commits intofrazane:mainfrom
Conversation
|
Thanks Tobi, looks good, sorry for taking so long to look at this. There is now a small merge conflict due to changes we've made to main (sorry about this). I can only address these by creating a new PR. The easiest solution would be if you merge with main on your local branch, solve the merge conflict, and push your changes. The only change should be to delete the old docs/api/crps.md file and add crps_csg0 in the relevant place (line 61, I think) in the new docs/reference.md file. I can then finally merge the PR. Thanks a lot! |
frazane
left a comment
There was a problem hiding this comment.
Hi Tobias, thanks very much for this contribution. Sorry for the delay, I just got back from holiday. Looks good to me, only a minor comment regarding references in the docstrings. Please fix that and we're good to merge! 👍
Overview
crps_csg0, the closed-form CRPS for a 0-censored, shifted Gamma distribution (Scheuerer & Hamill 2015, App. B).Implementation
csg0inscoringrules/core/crps/_closed.pyscoringrules/_crps.pyassr.crps_csg0__init__.pyexportsdocs/api/crps.mdTesting
shift=0matchescrps_gammashift>0